address comments

This commit is contained in:
Devon Rifkin
2025-09-15 11:46:25 -07:00
parent 47991940d4
commit 472feec2ff
4 changed files with 17 additions and 17 deletions

View File

@@ -307,7 +307,7 @@ true
"x": 3.14,
"y": 42,
"enabled": true,
"items": []interface{}{"a", "b", "c"},
"items": []any{"a", "b", "c"},
},
},
},
@@ -510,44 +510,44 @@ func TestQwenToolCallValueParsing(t *testing.T) {
desc: "array of strings",
paramType: api.PropertyType{"array"},
raw: `["foo", "bar", "baz"]`,
want: []interface{}{"foo", "bar", "baz"},
want: []any{"foo", "bar", "baz"},
},
{
desc: "array of numbers",
paramType: api.PropertyType{"array"},
raw: `[1, 2.5, 3]`,
want: []interface{}{float64(1), 2.5, float64(3)},
want: []any{float64(1), 2.5, float64(3)},
},
{
desc: "array of mixed types",
paramType: api.PropertyType{"array"},
raw: `["string", 123, true, null]`,
want: []interface{}{"string", float64(123), true, nil},
want: []any{"string", float64(123), true, nil},
},
{
desc: "empty array",
paramType: api.PropertyType{"array"},
raw: `[]`,
want: []interface{}{},
want: []any{},
},
// Object parsing tests
{
desc: "simple object",
paramType: api.PropertyType{"object"},
raw: `{"key": "value", "number": 42}`,
want: map[string]interface{}{"key": "value", "number": float64(42)},
want: map[string]any{"key": "value", "number": float64(42)},
},
{
desc: "nested object",
paramType: api.PropertyType{"object"},
raw: `{"outer": {"inner": "value"}}`,
want: map[string]interface{}{"outer": map[string]interface{}{"inner": "value"}},
want: map[string]any{"outer": map[string]any{"inner": "value"}},
},
{
desc: "empty object",
paramType: api.PropertyType{"object"},
raw: `{}`,
want: map[string]interface{}{},
want: map[string]any{},
},
// Error cases and fallback behavior
{
@@ -689,19 +689,19 @@ func TestQwenToolCallValueParsing(t *testing.T) {
desc: "array or object union - valid array",
paramType: api.PropertyType{"array", "object"},
raw: `[1, 2, 3]`,
want: []interface{}{float64(1), float64(2), float64(3)},
want: []any{float64(1), float64(2), float64(3)},
},
{
desc: "array or object union - valid object",
paramType: api.PropertyType{"array", "object"},
raw: `{"key": "value"}`,
want: map[string]interface{}{"key": "value"},
want: map[string]any{"key": "value"},
},
{
desc: "object or array union - valid array (precedence test)",
paramType: api.PropertyType{"object", "array"},
raw: `[1, 2, 3]`,
want: []interface{}{float64(1), float64(2), float64(3)},
want: []any{float64(1), float64(2), float64(3)},
},
{
desc: "complex multi-type union - null",